Skip to content

fix #3330 - fix hoverChanged for traces with pointNumbers #3345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2018
Merged

fix #3330 - fix hoverChanged for traces with pointNumbers #3345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/components/fx/hover.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1565,8 +1565,11 @@ function hoverChanged(gd, evt, oldhoverdata) {
for(var i = oldhoverdata.length - 1; i >= 0; i--) {
var oldPt = oldhoverdata[i];
var newPt = gd._hoverdata[i];

if(oldPt.curveNumber !== newPt.curveNumber ||
String(oldPt.pointNumber) !== String(newPt.pointNumber)) {
String(oldPt.pointNumber) !== String(newPt.pointNumber) ||
String(oldPt.pointNumbers) !== String(newPt.pointNumbers)
) {
return true;
}
}
Expand Down
40 changes: 31 additions & 9 deletions test/jasmine/tests/hover_label_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -942,7 +942,6 @@ describe('hover info', function() {
describe('histogram hover info', function() {
it('shows the data range when bins have multiple values', function(done) {
var gd = createGraphDiv();
var pts;

Plotly.plot(gd, [{
x: [0, 2, 3, 4, 5, 6, 7],
Expand All @@ -954,18 +953,15 @@ describe('hover info', function() {
margin: {l: 0, t: 0, r: 0, b: 0}
})
.then(function() {
gd.on('plotly_hover', function(e) { pts = e.points; });
var pts = null;
gd.once('plotly_hover', function(e) { pts = e.points; });

_hoverNatural(gd, 250, 200);
assertHoverLabelContent({
nums: '3',
axis: '3 - 5'
});
})
.then(function() {
assertHoverLabelContent({nums: '3', axis: '3 - 5'});
if(pts === null) fail('no hover evt triggered');
expect(pts.length).toBe(1);
var pt = pts[0];

var pt = pts[0];
expect(pt.curveNumber).toBe(0);
expect(pt.binNumber).toBe(1);
expect(pt.pointNumbers).toEqual([2, 3, 4]);
Expand All @@ -976,6 +972,32 @@ describe('hover info', function() {
expect(pt.xaxis).toBe(gd._fullLayout.xaxis);
expect(pt.yaxis).toBe(gd._fullLayout.yaxis);
})
.then(function() {
var pts = null;
gd.once('plotly_hover', function(e) { pts = e.points; });

_hoverNatural(gd, 250, 200);
expect(pts).toBe(null, 'should not emit hover event on same pt');
})
.then(function() {
var pts = null;
gd.once('plotly_hover', function(e) { pts = e.points; });

_hoverNatural(gd, 350, 200);
assertHoverLabelContent({nums: '2', axis: '6 - 8'});
expect(pts.length).toBe(1);

var pt = pts[0];
expect(pt.curveNumber).toBe(0);
expect(pt.binNumber).toBe(2);
expect(pt.pointNumbers).toEqual([5, 6]);
expect(pt.x).toBe(7);
expect(pt.y).toBe(2);
expect(pt.data).toBe(gd.data[0]);
expect(pt.fullData).toBe(gd._fullData[0]);
expect(pt.xaxis).toBe(gd._fullLayout.xaxis);
expect(pt.yaxis).toBe(gd._fullLayout.yaxis);
})
.catch(failTest)
.then(done);
});
Expand Down