Regression bug fix to draw 3d traces after heatmap

[archmoj]

Fixes #3359 by not calling autoType function on z axis for 3d traces after axis type was to multicategory by heatmap trace.
@etpinard

[etpinard]

That works. But opts.noMultiCategory should already be true from

plotly.js/src/plots/cartesian/type_defaults.js

Line 60 in 9beb88d

var opts = {noMultiCategory: !traceIs(d0, 'cartesian') || traceIs(d0, 'noMultiCategory')};

I suspect d0 in this scope is fullData[0] when it should be the first trace on the gl3d subplot.

I hope that makes sense 😄

[archmoj]

You are right. It seems to be the first trace on fullData which is not invisible.
The issue is not only affected 3d traces. The example below also fails on 'latest':

Plotly.newPlot(gd, {
    "data": [
      {
        "type": "heatmap",
        "x": [0, 1, 2],
        "y": [0, 1, 2],
        "z": [
          [0, 1, 0],
          [1, 0, 1],
          [0, 1, 0]
        ]
      },
      {
        "type": "scattergl",
        "x": [0, 1, 2],
        "y": [0, 1, 2]
      }
    ],
    "layout": {
        "title": "scattergl plot on top of 2d heatmap",
        "width": 600,
        "height": 400
    }
});

[archmoj]

@etpinard The 2d case was mentioned above failed on v.1.43.0; but works on master. So I would fetch master changes and fix this for the 3D case as you mentioned.

[etpinard]

Nicely done, but let's ♻️

plotly.js/src/plots/get_data.js

Lines 89 to 126 in 0078626

	/**
	* Get the data trace(s) associated with a given subplot.
	*
	* @param {array} data plotly full data array.
	* @param {string} type subplot type to look for.
	* @param {string} subplotId subplot id to look for.
	*
	* @return {array} list of trace objects.
	*
	*/
	exports.getSubplotData = function getSubplotData(data, type, subplotId) {
	if(!Registry.subplotsRegistry[type]) return [];
	var attr = Registry.subplotsRegistry[type].attr;
	var subplotData = [];
	var trace, subplotX, subplotY;
	if(type === 'gl2d') {
	var spmatch = subplotId.match(SUBPLOT_PATTERN);
	subplotX = 'x' + spmatch[1];
	subplotY = 'y' + spmatch[2];
	}
	for(var i = 0; i < data.length; i++) {
	trace = data[i];
	if(type === 'gl2d' && Registry.traceIs(trace, 'gl2d')) {
	if(trace[attr[0]] === subplotX && trace[attr[1]] === subplotY) {
	subplotData.push(trace);
	}
	}
	else {
	if(trace[attr] === subplotId) subplotData.push(trace);
	}
	}
	return subplotData;
	};

[archmoj]

@etpinard The try to reuse the getSubPlotData function was not successful.
Could I revert this change?

[archmoj]

Many thanks @etpinard for the help figuring this out!
Now the tests are all passed.

[etpinard]

Nice fix 💃 !