Surface additional checks for handling empty z arrays and minimum number of rows and columns #3365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
required minimum 2x2 data for a surface revised conditions for z correct z length check new baseline added
etpinard
reviewed
Dec 21, 2018
| @@ -0,0 +1,33 @@ | |||
| { | |||
| "data": [ | |||
There was a problem hiding this comment.
Could we turn these test cases into jasmine tests instead? This surface_test.js block
should be a nice place to test the default logic.
etpinard
reviewed
Dec 21, 2018
src/traces/surface/defaults.js
Outdated
| var z = coerce('z'); | ||
| if(!z) { | ||
| if(!z || !z.length || | ||
| (x ? (x.length < 2) : false) || |
There was a problem hiding this comment.
I would prefer keeping things consistent with contour traces here. 1-item contour traces are (like 1-item surfaces) ill-defined, but still appear as visible: true in the fullData (see -> https://codepen.io/etpinard/pen/oJZyEO)
To avoid drawing errors, we should handle the 1-item case in surface/convert.js. Thanks!
There was a problem hiding this comment.
The minimum for rows and columns are set to be one.
And it seems we won't get errors for those 1-item cases.
|
Nicely done 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3364.
The surface trace would be invisible if the z array is defined but is empty or when the columns/row array includes less than two items.
@etpinard