Updating dependencies of gl-vis modules

[archmoj]

Various gl-vis modules are updated e.g. to use glslify 6.4.1, etc.

@etpinard
CC: @plotly/plotly_js

[etpinard]

Is glslify the only module you updated in our gl-vis deps? Sorry for being lazy and not checking your commits myself 😄

[etpinard]

Hmm. That seems off. Looks like glslify didn't get dedupe.

Can you run npm ls glslify and paste its result here?

[archmoj]

There are other packages (i.e. one layer deep) that updated to the latest for each module.
So it could be a preparation before the third attempt on: #3267
Now all at glslify 7.0.0.
Here is what npm ls glslify show:

├─┬ gl-cone3d@1.2.1 (git://github.com/gl-vis/gl-cone3d.git#08ac6285dd38c2718593de178a5ec471409f34bf) │ └── glslify@7.0.0 ├─┬ gl-contour2d@1.1.4 (git://github.com/gl-vis/gl-contour2d.git#5de59b0654b6dd0f69588efecd6af63ab485bf2b) │ └── glslify@7.0.0 ├─┬ gl-error3d@1.0.10 (git://github.com/gl-vis/gl-error3d.git#33a049e477b384a1a99f2f3d6d55b211d0334d71) │ └── glslify@7.0.0 ├─┬ gl-heatmap2d@1.0.4 (git://github.com/gl-vis/gl-heatmap2d.git#9e41db108e22688625e9f16f48729482433aaa8f) │ └── glslify@7.0.0 ├─┬ gl-line3d@1.1.7 (git://github.com/gl-vis/gl-line3d.git#907b42266a48f0da6ecfecb405d70faa518f2380) │ └── glslify@7.0.0 ├─┬ gl-mesh3d@2.0.3 (git://github.com/gl-vis/gl-mesh3d.git#3256473ac4b8379a5d0a20c73676018c679d70e5) │ └── glslify@7.0.0 ├─┬ gl-plot2d@1.4.0 (git://github.com/gl-vis/gl-plot2d.git#635e24c218590ce332a98aa0258cde6214a64d64) │ └── glslify@7.0.0 ├─┬ gl-plot3d@1.6.1 (git://github.com/gl-vis/gl-plot3d.git#b2d4817d54341b337f7acd936cff565ebcc1bec3) │ ├─┬ gl-axes3d@1.4.2 (git://github.com/gl-vis/gl-axes3d.git#a65c444baafc50c9e46b8a91ecddb9bdd23fb676) │ │ └── glslify@7.0.0 │ ├─┬ gl-spikes3d@1.0.7 (git://github.com/gl-vis/gl-spikes3d.git#3aaf3b028d4afdaafff928b5f63a8ece58e9050e) │ │ └── glslify@7.0.0 │ └── glslify@7.0.0 ├─┬ gl-pointcloud2d@1.0.1 (git://github.com/gl-vis/gl-pointcloud2d.git#d0d0d20991b175083e3e5870e44a069219894ce7) │ └── glslify@7.0.0 ├─┬ gl-scatter3d@1.1.2 (git://github.com/gl-vis/gl-scatter3d.git#5b73a48623f61b6ff5dbbe25fde764e024403528) │ └── glslify@7.0.0 ├─┬ gl-select-box@1.0.2 (git://github.com/gl-vis/gl-select-box.git#6774f655862bd10c6d69a0f147c4c5ce825f0e92) │ └── glslify@7.0.0 ├─┬ gl-streamtube3d@1.1.1 (git://github.com/gl-vis/gl-streamtube3d.git#97024a61c753475cf4aab19600582425a07f7083) │ └── glslify@7.0.0 ├─┬ gl-surface3d@1.4.0 (git://github.com/gl-vis/gl-surface3d.git#31d6995fe20eb230a06c886a160456e9daf3ad69) │ └── glslify@7.0.0 ├── glslify@7.0.0 ├─┬ regl-line2d@3.0.12 (git://github.com/gl-vis/regl-line2d.git#10244979d972a52e983c39a47090d1ac8137d242) │ └── glslify@7.0.0 deduped └─┬ regl-scatter2d@3.1.2 (git://github.com/gl-vis/regl-scatter2d.git#40145179d549513bee2b44abd287514213d841f6) └── glslify@7.0.0

[etpinard]

Ok,

nicely done. 💪

Go ahead and bump the gl-vis modules' versions.

[archmoj]

@etpinard missing npm permission to publish this patch. Hopefully @dy would help?

[etpinard]

I don't have npm publish rights for regl-error2d either 😢

[etpinard]

-> gl-vis/regl-error2d#3 🤞

[etpinard]

@archmoj you should now have npm publish rights.

[archmoj]

I do have. Let me publish the new package. Thanks @etpinard.

[etpinard]

Could you check npm ls binary-search-bounds? I think I tried using binary-search-bounds@2.x in gl3d, but I don't think that worked out. We should double-check.

[archmoj]

Thanks for the note. This test branch related to gl3d (dep2019...dep2019-binary-search) passed on CI.

[archmoj]

And here is the tree.

├─┬ 3d-view@2.0.0 (git://github.com/archmoj/3d-view.git#b45ff1ea06664dbbd72c758eb323e7d99b56bcf5)
│ └─┬ orbit-camera-controller@3.0.0 (git://github.com/archmoj/orbit-camera-controller.git#96ea78ca5b7f925b9cba50773915135d3665c5ee)
│   └─┬ filtered-vector@1.2.4 (git://github.com/archmoj/filtered-vector.git#eead60dee81f3d071e9766b45a1343f48a38ccd8)
│     └── binary-search-bounds@2.0.4 
├─┬ gl-contour2d@1.1.5
│ ├── binary-search-bounds@2.0.4 
│ └─┬ cdt2d@1.0.0
│   └── binary-search-bounds@2.0.4 
├─┬ gl-heatmap2d@1.0.5
│ └── binary-search-bounds@2.0.4 
├─┬ gl-line3d@1.1.8
│ └── binary-search-bounds@2.0.4 
├─┬ gl-plot2d@1.4.1
│ └── binary-search-bounds@2.0.4 
├─┬ gl-scatter3d@1.1.3
│ └─┬ vectorize-text@3.2.0
│   └─┬ planar-graph-to-polyline@1.0.5
│     └─┬ point-in-big-polygon@2.0.0
│       ├── binary-search-bounds@1.0.0 
│       ├─┬ interval-tree-1d@1.0.3
│       │ └── binary-search-bounds@1.0.0  deduped
│       └─┬ slab-decomposition@1.0.2
│         └── binary-search-bounds@1.0.0  deduped
├─┬ gl-surface3d@1.4.1
│ └── binary-search-bounds@2.0.4 
├─┬ matrix-camera-controller@2.1.3 (git://github.com/archmoj/matrix-camera-controller.git#c0f6874c35c2d980297c2b625c2bebd48b89ffff)
│ └── binary-search-bounds@2.0.4 
└─┬ point-cluster@3.1.4
  └── binary-search-bounds@2.0.4

[etpinard]

@archmoj this here is now the only potentially-blocking item.

What are the differences between binary-search-bounds v1.x and v2.x?

[archmoj]

I think we may leave that for another PR. It seems that I don't have permission to patch and publish those modules...

[archmoj]

mikolalysenko/binary-search-bounds@d047eee#diff-b9cfc7f2cdf78a7f4b91a753d10865a2
This may be relevant to the difference between version 1 and 2.
ndarrays are not supported in Version 2.

[etpinard]

Ok, some before and after:

on master:

now on this branch:

which is 🎉 , and

which, as you pointed out, only has mikolalysenko/binary-search-bounds@d047eee diff between v1.x and v2.x. So I'd call this an improvement!

[etpinard]

@archmoj let's merge this in 💃

Our gl-vis modules have never been this well maintained!

[archmoj]

Thanks @etpinard for another encouraging and great review.
Yes I think we may merge this earlier so that to give the team more time to possibly test any side effect before the v.1.44.0 release.