Renaming old attributes should not replace existing current attributes if both provided #3423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
reviewed
Jan 9, 2019
src/plot_api/helpers.js
Outdated
| // scl->scale, reversescl->reversescale | ||
| if('scl' in trace) { | ||
| trace.colorscale = trace.scl; | ||
| if(!('colorscale' in trace)) { trace.colorscale = trace.scl; } |
There was a problem hiding this comment.
Could this be just one if-statement?
if('scl' in trace && !('colorscale' in trace)) {
// ...
}?
There was a problem hiding this comment.
It could be namely if we want to leave scl on the input trace in that scenario.
etpinard
reviewed
Jan 9, 2019
test/jasmine/tests/plot_api_test.js
Outdated
|
|
||
| Plotly.plot(gd, data); | ||
| expect(gd.data[0].colorscale).toBe('Greens'); | ||
| expect(gd.data[0].scl).toBe(undefined); |
There was a problem hiding this comment.
.... this here would be 'Reds', but that's not a big deal, right?
There was a problem hiding this comment.
Yes now that the logic changed it should not be undefined.
Done in 168bb68
etpinard
reviewed
Jan 9, 2019
test/jasmine/tests/plot_api_test.js
Outdated
| expect(gd.data[0].reversescl).toBe(undefined); | ||
| }); | ||
|
|
||
| it('should not rename \'scl\' to \'colorscale\' when colorscale is defined ', function() { |
There was a problem hiding this comment.
Wrong description it looks like
|
💃 - thanks for fixing 4+ year-old deprecation logic 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3419
@plotly/plotly_js