Skip to content

replace prepend() calls since they aren't supported in IE11 #3491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2019
Merged

replace prepend() calls since they aren't supported in IE11 #3491

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c70f9a
replace prepend() calls since they aren't supported in IE11
antoinerg Jan 28, 2019
4b164a2
prepend modebar with vanilla javascript
antoinerg Jan 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/components/modebar/modebar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ proto.update = function(graphInfo, buttons) {
}

if(fullLayout.modebar.orientation === 'v') {
this.element.prepend(logoGroup);
d3.select(this.element).insert(function() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Does

d3.select(this.element).insert(logoGroup, ':first-child');

work also?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that initially but it does not work:
screenshot_2019-01-28_17-07-49

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ha right, does

d3.select(this.element).insert(d3.select(logoGroup), ':first-child');

work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d3.select(this.element).insert(d3.select(logoGroup), ':first-child');

Also fails with:
screenshot_2019-01-28_17-18-23

Would you prefer that I to turn the snippet from this PR into a one-liner?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thanks for checking!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non- 🚫, but at that point the vanilla solution seems simpler:

plotly.js/src/plot_api/subroutines.js

Line 148 in ea7941b

pgNode.insertBefore(plotgroupBg.node(), pgNode.childNodes[0]);

plotly.js/src/lib/svg_text_utils.js

Lines 105 to 106 in ea7941b

newSvg.node().insertBefore(_glyphDefs.node().cloneNode(true),
newSvg.node().firstChild);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alexcjohnson! I agree it is simpler. Done in commit 4b164a2

Updated demo https://plnkr.co/edit/3Rfo4svtr6PUDCiCRM3l?p=preview

return logoGroup;
}, ':first-child');
} else {
this.element.appendChild(logoGroup);
}
Expand Down
12 changes: 12 additions & 0 deletions test/jasmine/assets/unpolyfill.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,17 @@
].join(' '));
}
});

Object.defineProperty(item, 'prepend', {
configurable: true,
enumerable: true,
writable: true,
value: function remove() {
throw Error([
'test/jasmine/assets/unpolyfill.js error: calling ChildNode.prepend()',
'which is not available in IE.'
].join(' '));
}
});
});
})([Element.prototype, CharacterData.prototype, DocumentType.prototype]);