Skip to content

Conversation

antoinerg
Copy link
Contributor

Fixes #3471

We now insert hoverlabels in a third svg element right after the modebar. This ensures that hoverlabels are always visible:
screenshot_2019-02-28_17-44-55

We also 🔪 z-index for the modebar: it is now sandwiched based on its position in the DOM. This should fix the following issue seen in a Dash app where the z-index:1001 really was problematic:
53552498-b65a6f00-3b3b-11e9-805c-e37bba0753b2

@antoinerg antoinerg added bug something broken status: reviewable labels Mar 1, 2019
@etpinard
Copy link
Contributor

etpinard commented Mar 1, 2019

Nice fix!

Adding a new .main-svg svg node to ALL our graphs might be a bit too much for a patch release. So, I'll slide this one in the 1.46.0 milestone and let's wait a few days before merging it

@etpinard etpinard added this to the v1.46.0 milestone Mar 1, 2019
@etpinard
Copy link
Contributor

good to merge 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug something broken

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Always overlap modebar with hoverlabels

2 participants