Skip to content

Don't try to access textfont when bar has no text #3715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

Don't try to access textfont when bar has no text #3715

merged 1 commit into from
Apr 2, 2019
+23 −9

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Apr 2, 2019

fixes #3714 - a fixup of my #3701

@etpinard etpinard added bug something broken status: reviewable labels Apr 2, 2019
@etpinard
Copy link
Contributor Author

etpinard commented Apr 2, 2019

cc @plotly/plotly_js

@archmoj
Copy link
Contributor

archmoj commented Apr 2, 2019

Thanks for the PR.
💃 when you get all the green tests.

@etpinard etpinard merged commit e8d300b into master Apr 2, 2019
@etpinard etpinard deleted the bar-textfont-wo-fix branch April 2, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug something broken

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Presence of textfont without text mangles bar traces

2 participants

@etpinard @archmoj