Fix Plotly.animate on graphs with multiple basePlotModules #3860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that sunburst clicks do not attempt to redraw cartesian
traces.
... making it smoothly transition with Plotly.react
|
cc @plotly/plotly_js |
archmoj
reviewed
May 13, 2019
| @@ -0,0 +1,121 @@ | |||
| { | |||
There was a problem hiding this comment.
Nicely done.
Could we reuse this mock instead?
test/image/baselines/display-text_zero-number.png
There was a problem hiding this comment.
What's wrong with the mock I used?
There was a problem hiding this comment.
Ha I see, that mock also has a sunburst along with cartesian traces. Yep, good call. Thanks!
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3849
before: https://codepen.io/MojtabaSamimi/pen/ardKoa?editors=0010
after: https://codepen.io/etpinard/pen/EzgzGQ?editors=1010