Use sane-topojson v3 #3874
Merged
Use sane-topojson v3 #3874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to improve fix for #3779
|
N.B. this PR is based off #3856 |
|
The only changes I notice are Crimea transferring to Russia (accurate, whatever one thinks of its propriety) and in geo_canadian-cites (quelqu'un a oublié l'accent sur "cité"?) it seems Canada has lost a bunch of lakes, including the Quebec Eye. Much as I like lakes I don't think this is a big deal, and I don't think we should support multiple versions. |
correct,
has 68 fewer lakes for some reason. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
sane-topojsonpackage is about to get a major upgrade etpinard/sane-topojson#12:subunitslayer properties (with keygu) allowing us to fix USA-states incorrectly drawn as foreign regions in high resolution choropleth #3779 in an un-hacky way unlike 68bd47bThat said, the new topojsons are different then the current ones. Not by much (see 4eb79b9, 4336c30 and etpinard/sane-topojson@8624ec4 to dig deeper), but they are different. As we don't version the topojsons on our CDN (e.g. at https://cdn.plot.ly/world_110m.json) used by default by
Plotly.newPlot, I'm a little reluctant to just merge this in. Perhaps we should retire the un-version URLs and start using e.g. https://cdn.plot.ly/world_v3.0.0_110m.json where thevX.Y.Zwould correspond to thesane-topojsonversion?Oh well, maybe I'm overthinking this. We did "override" the topojsons URLs back in #1077 and we didn't hear anyone complain about it.
I'm interested in hearing what @plotly/plotly_js will have to say.