Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gs.l not margin.l to position rangeslider #4127

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

etpinard
Copy link
Contributor

fixes #1096

cc @plotly/plotly_js

@etpinard etpinard added bug something broken status: reviewable labels Aug 14, 2019
@@ -0,0 +1,123 @@
{
Copy link
Contributor Author

@etpinard etpinard Aug 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mock currently looks like:

image

@etpinard
Copy link
Contributor Author

Ping @plotly/plotly_js - I'd like to get this in this week's 1.49.3 release.

@archmoj
Copy link
Contributor

archmoj commented Aug 19, 2019

Good catch!
💃

@etpinard etpinard merged commit 3103fd7 into master Aug 19, 2019
@etpinard etpinard deleted the rangeslider-l-positioning-fix branch August 19, 2019 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Legend or/and range slider auto margin don't behave with default margin settings
2 participants