Fix tiny zoombox behavior #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- this requirement can lead to visible 1d or 2d zoomboxes that do not lead to an axis range relayout, leading to confusing behaviour - lock this down in a test making sure small zoomboxes lead are followed by relayout calls.
- that drag(LASSO_PATH) call used to lead a no zoom, so this test did not properly check for seletedpoints persistence after zoom
|
Brilliant fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4156
where zoomboxes smaller than
2*MINDRAG=16pxnow lead to an axis range relayoutBefore:
After:
cc @plotly/plotly_js