Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamtube handle case of having starts but missing a dimension #4265

Merged
merged 2 commits into from
Oct 9, 2019
Merged

streamtube handle case of having starts but missing a dimension #4265

merged 2 commits into from
Oct 9, 2019

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Oct 9, 2019

@archmoj archmoj added bug something broken status: reviewable labels Oct 9, 2019
@etpinard
Copy link
Contributor

etpinard commented Oct 9, 2019

This is better than before - thanks 💃

At some point, it would be nice to handle "partial" starts settings with a mesh equivalent to our x and dx attributes we use in e.g scatter* traces.

We can discuss this further in #2781

@archmoj archmoj merged commit 25fe1c9 into master Oct 9, 2019
@archmoj archmoj deleted the streamtube-starts-length branch October 9, 2019 14:32
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

streamtube throws error when missing one start position
2 participants
@archmoj @etpinard