Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updatemenus toggle buttons via args2 #4305

Merged
merged 2 commits into from
Oct 25, 2019
Merged

Conversation

etpinard
Copy link
Contributor

resolves #4042

example: https://codepen.io/etpinard/pen/WNNOQoj

cc @archmoj - this is the last feature required for v1.51.0

- this set of arguments is passed the set button `method`
  when the button is in the active state.
@etpinard etpinard added this to the v1.51.0 milestone Oct 25, 2019
@etpinard
Copy link
Contributor Author

... and cc @alexcjohnson who asked for this feature.

@archmoj
Copy link
Contributor

archmoj commented Oct 25, 2019

Looking pretty good to me.
I am not sure about 'args2' naming though.
What about using arglist or extraargs?

@etpinard
Copy link
Contributor Author

I am not sure about 'args2' naming though.

Why not, we have axis, axis2?

@archmoj
Copy link
Contributor

archmoj commented Oct 25, 2019

OK. Resolved.

@archmoj
Copy link
Contributor

archmoj commented Oct 25, 2019

Nicely done.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "toggle legend" button
2 participants