Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear relinked cmin/cmax values in shared axes #4366

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

etpinard
Copy link
Contributor

... early in Plots.doCalcata, such that the cross-trace cmin/cmax aggregation starts from scratch.

This fixes #4337 - a bug that originates from the first shared coloraxis implementation (cf #3803 5bb341e)

before: https://codepen.io/nicolaskruchten/pen/YzzLXmy?editors=0010
after: https://codepen.io/etpinard/pen/rNNPvxy?editors=0010

before: https://codepen.io/alexcjohnson/pen/JjjwBKE
after: https://codepen.io/etpinard/pen/gOOqzPE

cc @archmoj

... early in Plots.doCalcata, such that the cross-trace
    cmin/cmax aggregation starts from scratch
@etpinard etpinard added bug something broken status: reviewable labels Nov 19, 2019
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@etpinard
Thanks very much for the PR.
Please find my questions below:

src/plots/plots.js Show resolved Hide resolved
src/plots/plots.js Show resolved Hide resolved
@archmoj
Copy link
Contributor

archmoj commented Nov 20, 2019

@etpinard thanks very much for the info.
💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

coloraxis range not react()ing
2 participants