Skip to content

Fix bug wheel event for IE. #4385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 26, 2020
Merged

Fix bug wheel event for IE. #4385

Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5927343
Fix bug wheel event for IE.
Nov 25, 2019
9f6afbe
Fix bug wheel event for IE
Nov 26, 2019
a8f62c3
Merge pull request #1 from plotly/master
MaksimLysakou May 22, 2020
84dbebb
Fix bug wheel event for IE.
Nov 25, 2019
dca3f97
Fix bug wheel event for IE
Nov 26, 2019
3127d52
fix typo (add negation for isAddedWheelEvent statement)
May 23, 2020
243eb21
Merge remote-tracking branch 'origin/vadzimZgerski/fixbug-wheel-event…
May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/plots/cartesian/dragbox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1202,6 +1202,10 @@ function attachWheelEventHandler(element, handler) {
if(!supportsPassive) {
if(element.onwheel !== undefined) element.onwheel = handler;
else if(element.onmousewheel !== undefined) element.onmousewheel = handler;
else if(element.isAddedWheelEvent) {
element.isAddedWheelEvent = true;
element.addEventListener('wheel', handler, {passive: false});
}
} else {
var wheelEventName = element.onwheel !== undefined ? 'wheel' : 'mousewheel';

Expand Down