Fix *toggleothers* behavior for graphs with traces not in legend #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etpinard
commented
Dec 3, 2019
| it('isolate trace in legend, ignore trace that is not in legend', function(done) { | ||
| Promise.resolve() | ||
| .then(click(0, 2)) | ||
| .then(assertVisible([true, 'legendonly', true])) |
There was a problem hiding this comment.
This used to result [true. 'legendonly', 'legendonly']
etpinard
commented
Dec 3, 2019
| it('isolate trace in legend, ignore trace that is not in legend (2)', function(done) { | ||
| Promise.resolve() | ||
| .then(click(1, 2)) | ||
| .then(assertVisible(['legendonly', true, true])) |
There was a problem hiding this comment.
This one used to result ['legendonly', true, 'legendonly']
alexcjohnson
approved these changes
Dec 4, 2019
etpinard
deleted the
legend-toggleothers-doot-hide-traces-not-in-legend
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4389
before: https://codepen.io/alexcjohnson/pen/MWWMVbr?editors=1010
after: https://codepen.io/etpinard/pen/VwYYWer?editors=1010
... and double-click either of the two legend items.
@plotly/plotly_js