Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colorbar of reversescale colorbars of heatmap-coloring contours #4437

Merged
merged 2 commits into from
Dec 20, 2019

Conversation

etpinard
Copy link
Contributor

@etpinard etpinard commented Dec 20, 2019

@etpinard etpinard added bug something broken status: reviewable labels Dec 20, 2019
@archmoj
Copy link
Contributor

archmoj commented Dec 20, 2019

Great! Could you please add a test for the case of using coloraxis as well?

@etpinard
Copy link
Contributor Author

Ok I'll add a subplot on the new mock.

But in my opinion, we don't need that as the trace-colorscale vs coloraxis logic is inside Colorscale.extractOpts which is already tested elsewhere.

@archmoj
Copy link
Contributor

archmoj commented Dec 20, 2019

If so, just testing in a codepen is enough.
Thank you!

@archmoj
Copy link
Contributor

archmoj commented Dec 20, 2019

Concerning before codepen it is better to use v.1.51.3 not the latest.

@etpinard
Copy link
Contributor Author

Concerning before codepen it is better to use v.1.51.3 not the latest.

Sure, edited above.

Great! Could you please add a test for the case of using coloraxis as well?

done in af025a2

@archmoj
Copy link
Contributor

archmoj commented Dec 20, 2019

💃 💃 after all green light on the CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

reversescale doesn't reverse colorbar on contour plot with coloring='heatmap'
2 participants