Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve text fit in treemap trace #4469

Merged
merged 2 commits into from
Jan 7, 2020
Merged

Improve text fit in treemap trace #4469

merged 2 commits into from
Jan 7, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jan 7, 2020 •
edited
Loading

This PR:

  • improves text fit scale when adjusted to left or right (by removing extra pad)
  • keeps constant text anchor positions when unifromtext rescales the sizes
  • avoids hidden elements (namely when using maxdepth) to impact uniform text size

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Jan 7, 2020
@archmoj archmoj added this to the v1.52.0 milestone Jan 7, 2020
etpinard
etpinard reviewed Jan 7, 2020
View reviewed changes
src/traces/bar/plot.js Outdated Show resolved Hide resolved
@etpinard
Copy link
Contributor

etpinard commented Jan 7, 2020

Great work @archmoj The updated baselines look very nice! I made one comment.

@etpinard
Copy link
Contributor

etpinard commented Jan 7, 2020

💃 - thanks!

@etpinard etpinard closed this Jan 7, 2020
@etpinard etpinard reopened this Jan 7, 2020
@etpinard
Copy link
Contributor

etpinard commented Jan 7, 2020

(I didn't mean to close this PR, I clicked on the wrong button, sorry)

@archmoj archmoj merged commit ba8d941 into master Jan 7, 2020
@archmoj archmoj deleted the treemap-textanchor branch January 7, 2020 18:53
@archmoj archmoj mentioned this pull request Jan 8, 2020
Closed
@jdamiba jdamiba mentioned this pull request Jan 9, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Feb 4, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Mar 18, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etpinard etpinard etpinard left review comments

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
v1.52.0
Development

Successfully merging this pull request may close these issues.
2 participants
@archmoj @etpinard