Implement surface opacityscale & correct display of transparent surfaces #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new gl-surface3d that supports opacityscale - move opacityscale logic from volume to surface in plotly.js - add new image tests for surface with opacityscale and opacity - update old surface baselines i.e. remove extra transparency issue 4478
archmoj
commented
Jan 10, 2020
package.json
Outdated
| @@ -88,7 +88,7 @@ | |||
| "gl-select-box": "^1.0.3", | |||
| "gl-spikes2d": "^1.0.2", | |||
| "gl-streamtube3d": "^1.4.0", | |||
| "gl-surface3d": "^1.4.6", | |||
| "gl-surface3d": "git://github.com/gl-vis/gl-surface3d.git#f42163793d1ef167358363f2264c5318bac8ceaa", | |||
There was a problem hiding this comment.
…aselines thanks to #4566
|
💃 - after bumping |
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4331 | demo
and
fixes #4478 | before vs after
This PR adds a new attribute titled
opacityscaletosurfacetrace.Using that it is possible to make certain parts of the surface plot more transparent.
Also this PR removes extra transparency displayed by surface plots which would match
surface.opacityandmesh3d.opacity.@plotly/plotly_js