Implement connect gaps for 2d WebGL plots #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc/ @monfera |
|
@mikolalysenko Something broke the
that line should be on follow the marker points. |
| @@ -28,6 +28,7 @@ | |||
| "cibuild": "node tasks/cibundle.js", | |||
| "watch": "node tasks/watch_plotly.js", | |||
| "lint": "eslint . || true", | |||
| "lint-fix": "eslint . --fix", | |||
|
@etpinard Looks like the xData and yData arrays aren't getting initialized correctly for that plot. I can take a look at it next time I get a day to work. |
| linePositions = new Float32Array(2 * x.length); | ||
|
|
||
| for(i=0; i<x.length; ++i) { | ||
| linePositions[p++] = x[i]; |
There was a problem hiding this comment.
you might have to ♻️ this block.
|
@etpinard just a quick ping: I fixed up the problem with the axes computations on some plots. Let me know if this looks good now. |
|
@mikolalysenko
The logs coordinates show up as |
|
Alright, taking another look |
|
Alright, I think I got the picking issue fixed. Let me know if there is anything else out of the ordinary here. |
|
@mikolalysenko Looks great. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements connect gaps for 2D webgl plots. It requires the following upgrades to gl-line2d:
gl-vis/gl-line2d@42172ed
This should solve the following issue:
https://github.com/plotly/phoenix-integration/issues/44
A new test case (
gl2d_connect_gaps) was added to the dashboard to verify that the feature is working:CC @bpostlethwaite @etpinard