Improve pie and sunburst inside text pad #4519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… computing radial and tangential options
|
The new baselines look good! Thanks for doing this @archmoj I'm not 100% comfortable releasing this into a patch, as the new pad value can be the difference between an inside text and an outside text. This would be a great addition to One small comment: it would be nice to combine all the new mocks in 6b8de97 into a single figure. |
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4518 by considering
TEXTPADsimilar to bar-like traceswhen computing scales for
radialandtangentialorientation options.Thanks very much in advance for reviewing revised baselines!
@plotly/plotly_js
cc: @nicolaskruchten