histogram: in hover labels, harmonize start/end values of shared bins #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archmoj
reviewed
Mar 18, 2020
src/traces/histogram/calc.js
Outdated
| roundFn = function(v, isRightEdge) { | ||
| return function() { | ||
| var roundFnOpts = gd._fullLayout._roundFnOpts[groupName]; | ||
| return getBinSpanLabelRound(roundFnOpts.leftGap, roundFnOpts.rightGap, binEdges, pa, calendar)(v, isRightEdge); |
There was a problem hiding this comment.
This line is getting little too long. Maybe:
return getBinSpanLabelRound(
roundFnOpts.leftGap,
roundFnOpts.rightGap,
binEdges, pa, calendar
)(v, isRightEdge);
archmoj
reviewed
Mar 18, 2020
| var roundFnOpts = {leftGap: Infinity, rightGap: Infinity}; | ||
| if(groupName) { | ||
| if(!gd._fullLayout._roundFnOpts[groupName]) gd._fullLayout._roundFnOpts[groupName] = roundFnOpts; | ||
| roundFnOpts = gd._fullLayout._roundFnOpts[groupName]; |
There was a problem hiding this comment.
Non-blocking,
We could rewrite this:
if(!gd._fullLayout._roundFnOpts[groupName]) {
gd._fullLayout._roundFnOpts[groupName] = roundFnOpts;
}
roundFnOpts = gd._fullLayout._roundFnOpts[groupName];to make it easier to read 3 gd._fullLayout._roundFnOpts[groupName].
|
This branch is little behind the master. |
|
|
Is there anything that landed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4648
Codepen: https://codepen.io/antoinerg/pen/LYVrJoZ
cc @nicolaskruchten | @plotly/plotly_js