-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve auto ticks over axes with rangebreaks #4677
Conversation
@archmoj huge improvement! I'm just seeing one problem in a few of the mocks: the second line (date part) of the tick label is missing on all but the first label; it should be present whenever the date changes. Somewhere we have code that compares adjacent tick labels and removes the second line when it matches the previous tick label, that's perhaps running too early, before the ticks and their text are fully defined? axes_breaks-night_autorange-reversed is in this screenshot, axes_breaks-weekends-weeknights also shows this. Interestingly, axes_breaks-weekends_autorange-reversed shows a change but I think I prefer the new behavior: the "first" tick of each new day is not the left-most or bottom-most, it's the earliest date. I could see arguments either way, but I think earliest date is better, as it labels the day (or month, or year, whatever) on the closest tick to when that period starts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. Thanks for opening #4679 to follow up on the last piece. 💃
Follow up of #4614,
This PR improves ticks over axes with
rangebreaks
and fixes #4666.Demos: Before vs After.
@plotly/plotly_js