Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement horizontal and vertical markers for arrow charts #5010

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Implement horizontal and vertical markers for arrow charts #5010

merged 2 commits into from
Jul 24, 2020

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Jul 22, 2020 •
edited
Loading

Resolves #4935 | demo

List of new symbols:

'arrow-up'
'arrow-down'
'arrow-left'
'arrow-right'
'arrow-bar-up'
'arrow-bar-down'
'arrow-bar-left'
'arrow-bar-right'

@plotly/plotly_js

@alexcjohnson
Copy link
Collaborator

Very nice! Just two comments:

  • These should have noDot: true, and the bar variants should have needLine: true (now, whether we're actually doing what we should with those flags is another matter...)
  • Instead of arrow-to-bar-up can we shorten to just arrow-bar-up?

alexcjohnson
alexcjohnson approved these changes Jul 22, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Beautiful!

@archmoj archmoj merged commit 9a8089c into master Jul 24, 2020
@archmoj archmoj deleted the arrow-markers branch July 24, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
feature something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Triangle markers that end on points rather than center on them
2 participants
@archmoj @alexcjohnson