relative barmode to stack negative values below axis #517
Conversation
| dflt: 'group', | ||
| role: 'info', | ||
| description: [ | ||
| 'Determines how bars at the same location coordinate', | ||
| 'are displayed on the graph.', | ||
| 'With *stack*, the bars are stacked on top of one another', | ||
| 'With *relative*, the bars are stacked on top of one another,', |
| { | ||
| "data":[ | ||
| {"name":"Col1","y":["-1","2","3","4","5"],"x":["1","2","3","4","5"],"type":"bar","uid":"aeb9ea"}, | ||
| {"name":"Col2","y":["2","3","4","-3","2"],"x":["1","2","3","4","5"],"type":"bar","uid":"2f201d"}, |
There was a problem hiding this comment.
Also, the uid should likely be removed from the mock - it's generated per-plot and we should keep mocks as lean as possible.
|
Great PR! I'm pulling it down and testing it out, but so far so good and we'll get this in for the next release. |
|
Circle shows some image tests failing - could you take a look at those @keeganmccallum (and fix the linting errors too)? You can go to the "artifacts" tab at the circle results and see which images failed - some are just for the new mocks you created (don't worry about those ones yet) but theres a few of the existing tests where no plot is getting created at all - most likely an error is thrown before plotting. If you're up to it, adding some jasmine tests would be great as well! |
|
hmmm, so I am not 100% familiar with the testing process, opening the mocks that "did not return image" in the circle tests doesn't show any issues, all of those mocks render fine in the test dashboard, no errors and are identical results to those rendered in the test dashboard in master. Is there some vector I am missing or should that indicate that the rendering is being performed correctly? EDIT: fixing the linting errors seems to have cleared this up nevermind |
|
The two images that are failing are the two you added so you may just need to re-run the image generation on them Thanks for doing this! |
| "y":["5","4","3","2","1"], | ||
| "x":["1","2","3","4","5"], | ||
| "type":"bar", | ||
| "uid":"aef0bf" |
There was a problem hiding this comment.
Sorry to keep adding more things that need changes but could you remove the uid here as well too please!
|
🎉 |
No description provided.