Skip to content

Set false locale #5293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Set false locale #5293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52b5051
address issue 5289 - set false locale
archmoj Nov 19, 2020
0a21710
address issue 5289 - use if block instead of loop
archmoj Nov 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/plots/plots.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,7 +667,7 @@ function emptySubplotLists() {
*/
function getFormatObj(gd, formatKeys) {
var locale = gd._context.locale;
if(!locale) locale === 'en-US';
if(!locale) locale = 'en-US';

var formatDone = false;
var formatObj = {};
Expand Down
5 changes: 2 additions & 3 deletions src/traces/histogram/cross_trace_defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,9 @@ module.exports = function crossTraceDefaults(fullData, fullLayout) {
}

var binGroupFound = false;
for(i = 0; i < traces.length; i++) {
traceOut = traces[i];
if(traces.length) {
traceOut = traces[0];
binGroupFound = coerce('bingroup');
break;
}

groupName = binGroupFound || groupName;
Expand Down