Drop legacy polar #5399
Merged
Drop legacy polar #5399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| '4', | ||
| '5', | ||
| '6', | ||
| '7', |
There was a problem hiding this comment.
And delete 6 and 8 (and their commented-out lines below), right?
There was a problem hiding this comment.
Should verify that all the @noCI tests still run before we merge this.
There was a problem hiding this comment.
Good eye.
Done in de6ca39.
And validated before submitting the PR.
There was a problem hiding this comment.
OIC, this line will skip missing figures
plotly.js/test/jasmine/tests/mock_test.js
Line 2178 in 1529f3b
That seems a little dangerous, but doesn't need to be addressed now.
alexcjohnson
approved these changes
Jan 13, 2021
This was referenced Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5395,
This PR drops legacy
polarandareatrace.It also drops
tandrfrom thescattertrace and dropslayout.radialaxisas well aslayout.angularaxisattributes.@plotly/plotly_js