Skip to content

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented May 5, 2021

Closes #5634

@plotly/plotly_js

@archmoj archmoj added this to the NEXT milestone May 5, 2021
@archmoj archmoj requested a review from alexcjohnson May 5, 2021 19:51
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💃
Sad to see the encoding issue pop up again though 🤯

@archmoj archmoj merged commit 9a583b4 into master May 5, 2021
@archmoj archmoj deleted the simplify-ensure-number branch May 5, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simplify Lib.ensureNumber

2 participants