Remove internal option layout.autosize='initial' (Fixes #537)
#576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Commit 5df675a (fix demo/outside legend bug and null data autoscale bug) introduced a guard in plotAutoSize to avoid calling layoutStyles while autosize is set to 'initial'. * Commit ee974d9 (autosizing in shareplots, autosize aspect ratio restrictions and ...) removed the call to layoutStyles but forgot to remove the guard. * This commit removes the guard. * Checked that all the jasmine and image tests still pass.
* Moved initial call to `plotAutoSize` into `Plots.supplyDefaults(gd)`.
* Replaced `{ autosize: 'initial' }` with the flag
`gd._fullLayout._initialAutoSizeIsDone`.
* `{ autosize: false }` the values of width and height undefined in
`gd.layout` will be autosized only once.
* `{ autosize: true }` only autosizes the values of width and height
undefined in `gd.layout`.
Fixes plotly#537
* Previous image didn't honour the width and height set in the layout.
* Added test to check `Plotly.newPlot` respects `layout.width` and `layout.height`.
n-riesco
changed the title
layout.autosize='initial' (Fixes #537)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plotAutoSizeintoPlots.supplyDefaults(gd).{ autosize: 'initial' }with the flaggd._fullLayout._initialAutoSizeIsDone.{ autosize: false }the values of width and height undefined ingd.layoutwill be autosized only once.{ autosize: true }only autosizes the values of width and heightundefined in
gd.layout.Fixes #537