Skip to content

autosize: Fix Plots.resize backwards-compatibility #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

n-riesco
Copy link
Contributor

@n-riesco n-riesco commented Jun 12, 2016

See this comment for context.

If this is the desired behaviour for Plots.resize(gd), I will add a test to the PR.

@etpinard
Copy link
Contributor

Great. This is one step toward backward compatibility.

But, we should also make sure that test cases like the one pointed in this comment don't need the extra { autosize: true } layout attribute for them to pass.

@etpinard etpinard added the bug something broken label Jun 13, 2016
@etpinard etpinard mentioned this pull request Jun 13, 2016
@etpinard
Copy link
Contributor

Closed in favor of #635

@etpinard etpinard closed this Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants