Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable interactions for slider when staticPlot is true #6393

Merged
merged 2 commits into from
Dec 13, 2022
Merged

disable interactions for slider when staticPlot is true #6393

merged 2 commits into from
Dec 13, 2022

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Dec 12, 2022

Fixes #6392.

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable labels Dec 12, 2022
alexcjohnson
alexcjohnson approved these changes Dec 12, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 with a changelog entry

@archmoj archmoj merged commit 0e2b249 into master Dec 13, 2022
@archmoj archmoj deleted the fix6392-static-slider branch December 13, 2022 00:10
@josephernest
Copy link

Thanks @archmoj, this is fast!

Is there a distribution version plotly-testing.min.js that is ready-to-use and contains these changes?

(I don't have the building tooling installed here to produce it)

@archmoj
Copy link
Contributor Author

archmoj commented Dec 13, 2022

@josephernest
You could use v2.16.5 release now.

@alexcjohnson alexcjohnson mentioned this pull request Dec 13, 2022
Open
@josephernest
Copy link

Thank you @archmoj! Is the main file I should use this one? plotly.js-2.16.5\dist\plotly.min.js?
PS: I tried <script src="https://cdn.plot.ly/plotly-2.16.5.js"></script> and it works from cdn!

@josephernest
Copy link

josephernest commented Dec 13, 2022 •
edited
Loading

Note @archmoj: it seems to work, but a small last thing: the mouse cursor on hover of the sliders still change to ew-resize , ie "movable" cursor, and it should not if staticPlot = true. Maybe for 2.16.5.2 ;)

@archmoj archmoj mentioned this pull request Dec 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
bug something broken
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

static slider
3 participants
@archmoj @josephernest @alexcjohnson