Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pie : add Pattern #6601

Merged
merged 11 commits into from
May 30, 2023
Merged

pie : add Pattern #6601

merged 11 commits into from
May 30, 2023

Commits on May 12, 2023

  1. pie : add Pattern

    Patterns were already added to a few trace types in Plotly, like bar & scatter.
    
    Hereby a first version to do so for pie charts, cf. Feature request: ability to add pattern fills to pie chart plotly#6134
    thierryVergult committed May 12, 2023
    Configuration menu
    Copy the full SHA
    342bd09 View commit details
    Browse the repository at this point in the history
  2. piePattern : add md & fix reference to colors

    only reference traceIn.marker.colors if traceIn.marker exists
    thierryVergult committed May 12, 2023
    Configuration menu
    Copy the full SHA
    1cce254 View commit details
    Browse the repository at this point in the history
  3. Update src/traces/pie/defaults.js

    Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
    thierryVergult and archmoj authored May 12, 2023
    Configuration menu
    Copy the full SHA
    fedbe67 View commit details
    Browse the repository at this point in the history
  4. piePattern : use the old point color when no shape present

    + plot-schema.json after running npm run schema
    thierryVergult committed May 12, 2023
    Configuration menu
    Copy the full SHA
    c24ae98 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2023

  1. piePattern : rework styleOne in case no colors defined

    fixes bug (trace.marker.shape) & logic.
    thierryVergult committed May 13, 2023
    Configuration menu
    Copy the full SHA
    e40e078 View commit details
    Browse the repository at this point in the history
  2. piePattern : extra check on trace.marker.pattern

    The styleOne function is also used by the funnelarea trace type, which has no pattern in it's schema at the moment, so extra check if pattern exists, before checking if a shape exists within the pattern.
    thierryVergult committed May 13, 2023
    Configuration menu
    Copy the full SHA
    a683c2a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. piePattern : fix broken tests

    funnelarea pixel tests were broken, so use the point color in way more cases
    thierryVergult committed May 14, 2023
    Configuration menu
    Copy the full SHA
    49319de View commit details
    Browse the repository at this point in the history
  2. piePattern : add mock

    add 5 pie charts, spread over the x domain, with increasing pattern functionalities
    thierryVergult committed May 14, 2023
    Configuration menu
    Copy the full SHA
    8cd2c97 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. piePattern : rework the index of legend items

    - take the index from the point in the styleOne function, instead of setting it before in the data structure
    - zz-pie_pattern : height 500
    thierryVergult committed May 17, 2023
    Configuration menu
    Copy the full SHA
    5d809b6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a422094 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f376b63 View commit details
    Browse the repository at this point in the history