Skip to content

Bug/pikul standoff position #6889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Bug/pikul standoff position #6889

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbb56f3
Add mocks for testing
ayjayt Feb 9, 2024
236e9a3
Fix calcLabelBBox to return sensible value when no label
ayjayt Feb 9, 2024
5503c70
Remove mocks to pass tests
ayjayt Feb 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/plots/cartesian/axes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2452,7 +2452,7 @@ axes.drawOne = function(gd, ax, opts) {
var llbboxes = {};
function getLabelLevelBbox(suffix) {
var cls = axId + (suffix || 'tick');
if(!llbboxes[cls]) llbboxes[cls] = calcLabelLevelBbox(ax, cls);
if(!llbboxes[cls]) llbboxes[cls] = calcLabelLevelBbox(ax, cls, mainLinePositionShift);
return llbboxes[cls];
}

Expand Down Expand Up @@ -2872,7 +2872,7 @@ function getDividerVals(ax, vals) {
return out;
}

function calcLabelLevelBbox(ax, cls) {
function calcLabelLevelBbox(ax, cls, mainLinePositionShift) {
var top, bottom;
var left, right;

Expand All @@ -2897,10 +2897,9 @@ function calcLabelLevelBbox(ax, cls) {
right = Math.max(right, bb.right);
});
} else {
top = 0;
bottom = 0;
left = 0;
right = 0;
var dummyCalc = axes.makeLabelFns(ax, mainLinePositionShift);
top = bottom = dummyCalc.yFn({dx: 0, dy: 0, fontSize: 0}); // I don't know what dx, dy is
left = right = dummyCalc.xFn({dx: 0, dy: 0, fontSize: 0});
}

return {
Expand Down