Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subtitle to plots #7012

Merged
merged 51 commits into from
Jul 18, 2024
Merged

Add subtitle to plots #7012

merged 51 commits into from
Jul 18, 2024

Commits on Jun 17, 2024

  1. add subtitle property and simple prototype

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    24ed9c9 View commit details
    Browse the repository at this point in the history

  2. add simple subtitle mock

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7469d8e View commit details
    Browse the repository at this point in the history

  3. coerce step for subtitle

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3afc2e7 View commit details
    Browse the repository at this point in the history

  4. fully-featured subtitles with plot options

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    13f8b2a View commit details
    Browse the repository at this point in the history

  5. add subtitle mock

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    cf5eb51 View commit details
    Browse the repository at this point in the history

  6. remove old mock

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    4a55ff2 View commit details
    Browse the repository at this point in the history

  7. fix subtitle placement when title is mathjax

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    625ea53 View commit details
    Browse the repository at this point in the history

  8. small cleanup of mathjax logic

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    972836e View commit details
    Browse the repository at this point in the history

  9. add mock testing font options with subtitle

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    f6e9781 View commit details
    Browse the repository at this point in the history

  10. streamline placeholder logic

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    35a6599 View commit details
    Browse the repository at this point in the history

  11. add subtitle to titles tests

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    60a6287 View commit details
    Browse the repository at this point in the history

  12. fix small bug in subtitle logic

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7eb9e52 View commit details
    Browse the repository at this point in the history

  13. syntax

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    7e9fcf9 View commit details
    Browse the repository at this point in the history

  14. re-add removed comment

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    3190382 View commit details
    Browse the repository at this point in the history

  15. fix title positioning

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    608740f View commit details
    Browse the repository at this point in the history

  16. french and spanish

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    183518c View commit details
    Browse the repository at this point in the history

  17. add config test for editable subtitle

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2452a48 View commit details
    Browse the repository at this point in the history

  18. add plot api react test for subtitle

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    8bce81b View commit details
    Browse the repository at this point in the history

  19. add image baselines for subtitle

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    2aca950 View commit details
    Browse the repository at this point in the history

  20. update plot-schema

    @emilykl
    emilykl committed Jun 17, 2024
    Configuration menu
    Copy the full SHA
    ade53d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. mark restyle radial axis title test as flaky

    @emilykl
    emilykl committed Jun 18, 2024
    2 Configuration menu
    Copy the full SHA
    13af030 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into add-subtitle

    @emilykl
    emilykl committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    b2a26e0 View commit details
    Browse the repository at this point in the history

  3. add draftlog

    @emilykl
    emilykl committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    2790ec7 View commit details
    Browse the repository at this point in the history

  4. add mathjax subtitle mock; add addl padding bw sutbtitle and title wh… 

    …en title is mathjax
    @emilykl
    emilykl committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    03638ee View commit details
    Browse the repository at this point in the history

  5. fix bug with colorbar title

    @emilykl
    emilykl committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    8210b58 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. fix placeholder positioning bug

    @emilykl
    emilykl committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    496ccc7 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. remove zz-subtitle-mathjax mock

    @archmoj
    archmoj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    15754fa View commit details
    Browse the repository at this point in the history

  2. add mathjax subtitle and title to ternary-mathjax

    @archmoj
    archmoj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f2cbc23 View commit details
    Browse the repository at this point in the history

  3. test positioning of subtitle when title is mathjax

    @archmoj
    archmoj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f3842e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. update draftlog

    @emilykl
    emilykl committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    e3813f2 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. fix subtitle position after editing when title is MathJax

    @emilykl
    emilykl committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e70e521 View commit details
    Browse the repository at this point in the history

  2. syntax

    @emilykl
    emilykl committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    e9e8adb View commit details
    Browse the repository at this point in the history

  3. fix error when no subtitle

    @emilykl
    emilykl committed Jun 28, 2024
    Configuration menu
    Copy the full SHA
    0d154bb View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2024

  1. syntax 

    Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
    @emilykl @archmoj
    emilykl and archmoj authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2aa2b8f View commit details
    Browse the repository at this point in the history

  2. change Object.assign to Lib.extendFlat 

    Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
    @emilykl @archmoj
    emilykl and archmoj authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    527ff8d View commit details
    Browse the repository at this point in the history

  3. use title and subtitle keys instead of t and st

    @emilykl
    emilykl committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    28d30ee View commit details
    Browse the repository at this point in the history

  4. remove extra newline 

    Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
    @emilykl @archmoj
    emilykl and archmoj authored Jul 8, 2024
    Configuration menu
    Copy the full SHA
    aa7b0a6 View commit details
    Browse the repository at this point in the history

  5. set subtitle font size based on title font size

    @emilykl
    emilykl committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    db5de4d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'add-subtitle' of https://github.com/plotly/plotly.js in… 

    …to add-subtitle
    @emilykl
    emilykl committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    154f481 View commit details
    Browse the repository at this point in the history

  7. change subtitle font size multiplier to 0.7

    @emilykl
    emilykl committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    6701eee View commit details
    Browse the repository at this point in the history

  8. change plotsubtitle key to subtitle

    @emilykl
    emilykl committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    313301c View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2024

  1. streamline logic

    @emilykl
    emilykl committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    423dfd3 View commit details
    Browse the repository at this point in the history

  2. Update src/plot_api/subroutines.js 

    Co-authored-by: Mojtaba Samimi <33888540+archmoj@users.noreply.github.com>
    @emilykl @archmoj
    emilykl and archmoj authored Jul 9, 2024
    Configuration menu
    Copy the full SHA
    cef06c8 View commit details
    Browse the repository at this point in the history

  3. adjust mathjax padding multiplier

    @emilykl
    emilykl committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    7cc019d View commit details
    Browse the repository at this point in the history

  4. render subtitle even if title is not present

    @emilykl
    emilykl committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    b7cda0b View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. better method of determining subtitle position

    @emilykl
    emilykl committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    ec166a3 View commit details
    Browse the repository at this point in the history

  2. update mathjax baselines

    @emilykl
    emilykl committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    8e44892 View commit details
    Browse the repository at this point in the history

  3. bbox bug

    @emilykl
    emilykl committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    e189245 View commit details
    Browse the repository at this point in the history

  4. update baselines

    @emilykl
    emilykl committed Jul 11, 2024
    Configuration menu
    Copy the full SHA
    de628de View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. take full title+subtitle height into account for automargin

    @emilykl
    emilykl committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    47a5b82 View commit details
    Browse the repository at this point in the history

  2. improved subtitle automargin positioning

    @emilykl
    emilykl committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    b8942ee View commit details
    Browse the repository at this point in the history