Skip to content

fix typos #7532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix typos #7532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/colorbar/draw.js
View file
Open in desktop
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change likely altered the result of some test images, which makes sense. You can download the new images from the Artifacts tab in the CircleCI results and save those into the test images folder and commit them.

Copy link
Author

@musvaage musvaage Aug 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

download the new images from the Artifacts tab in the CircleCI results

I'm unclear on how to do that.

test images folder

I'm unclear on the precise location of the "test images" folder.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll take care of it. It can be confusing if you're unfamiliar with the testing system.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you allow edits to the PR by maintainers?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allow edits from maintainers

I don't see that text and documentation on that invariably refer to a fork's user created branch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should show up on the PR as described here. If you aren't able to do that, I'll just create my own PR that incorporates your changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aren't able to do that

"you can modify an existing pull request to let repository maintainers make commits to your branch"

I used the master branch for this pull, maybe that's why the Allow edits... text doesn't appear.

I'll just create my own PR that incorporates your changes.

That seems to be the solution to this circumstance.

Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ function drawColorBar(g, opts, gd) {
ax.tickfont.size :
0
) + (
ax.ticks !== 'intside' ?
ax.ticks !== 'inside' ?
opts.ticklen || 0 :
0
);
Expand Down
2 changes: 1 addition & 1 deletion src/plot_api/plot_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ function assertExtendTracesArgs(gd, update, indices, maxPoints) {
(!(key in maxPoints) || !Array.isArray(maxPoints[key]) ||
maxPoints[key].length !== update[key].length)) {
throw new Error('when maxPoints is set as a key:value object it must contain a 1:1 ' +
'corrispondence with the keys and number of traces in the update object');
'correspondence with the keys and number of traces in the update object');
}
}
}
Expand Down
4 changes: 2 additions & 2 deletions test/jasmine/tests/plot_api_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1903,12 +1903,12 @@ describe('Test plot api', function() {
expect(function() {
Plotly.extendTraces(gd, {x: [[1]]}, [0], {y: [1]});
}).toThrow(new Error('when maxPoints is set as a key:value object it must contain a 1:1 ' +
'corrispondence with the keys and number of traces in the update object'));
'correspondence with the keys and number of traces in the update object'));

expect(function() {
Plotly.extendTraces(gd, {x: [[1]]}, [0], {x: [1, 2]});
}).toThrow(new Error('when maxPoints is set as a key:value object it must contain a 1:1 ' +
'corrispondence with the keys and number of traces in the update object'));
'correspondence with the keys and number of traces in the update object'));
});

it('should throw an error when update keys mismatch trace keys', function() {
Expand Down