-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Animate API #802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Animate API #802
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
57892ed
Animate API
rreusser ae7c54c
Partial draw: Correct traces selected based on fill
rreusser 4e23c21
Handle the case where no module found
rreusser b98be71
supplyDataDefaults instead of supplyDefaults for transitions
rreusser 00bfd52
Dragbox compares axes by value instead of reference
rreusser f46e5fb
Attempt simultaneous axis and data transitions
rreusser 981c1a8
Fall back to disallowing simultaneous data + axis transitions
rreusser 80078e4
lib function to interleave trace updates into a restyle
rreusser a36fb6e
Add supplyTransitionDefaults to coerce input
rreusser b249f7b
Remove unexposed cascade option
rreusser d06699d
Group transitions to avoid race conditions
rreusser 4ea79b2
Overhaul transition completion behavior
rreusser 639faa2
Trigger transition completion even if nothing else happened
rreusser 36207ee
Fixes from first review pass
rreusser 4834703
Fix broken tests
rreusser 6f0b42b
Mirror changes from #878 and small typo fix
rreusser a311922
Fix errorbar typo
rreusser d5c82c6
Add a tests for scatter simplify: false
rreusser 0f848ab
Fix the scatter select id field
rreusser a6be166
Disable mouse interaction during finite-duration transition
rreusser dd0b1f8
Expand the animate API
rreusser bd6e8c0
Rework transition and animate to resolve at the *end*
rreusser 1b497e3
Regroup animate tests to prevent race conditions
rreusser 9079632
Add a couple more purge tests
rreusser 14516cf
Tweak point enter/exit transitions
rreusser 9c83914
Write Plotly.transition out of the picture yayyy
rreusser ee95be1
Fix frame attributes
rreusser dfd2037
Update attributes to improve interop with animations
rreusser 82fefa9
Move point symbol style to single point style func
rreusser db6b942
Test moving transition and doCalcdata to plots.js
rreusser 0d3da5e
Change namespace of transition
rreusser 0221c79
Refactor animationOpts API
rreusser f3a292d
Apply non-range props from layout to transition
rreusser f709572
Use Lib.isPlainObject instead of typeof
rreusser 68b9a0c
Stop testing the things that don't pass the tests 😑
rreusser 29c14d7
Switch to window.[request|cancel]AnimationFrame for consistency
rreusser 84c93fe
Remove .transition from core
rreusser 75ec8a5
Add immediate interrupt
rreusser c8e46f2
Fix one of the animate tests
rreusser 1d43355
Tweak tests
rreusser 1fe652d
Fix race condition in .animate
rreusser 2bc29b8
Limit transition duration to <= frame duration
rreusser 0f23eef
jsDoc for animate, addFrames, and deleteFrames
rreusser c85c3a2
Verify gd is a plot div for animate, addFrames, deleteFrames
rreusser 4e88184
Throw animate API errors whne gd is not a plot
rreusser File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,7 +17,7 @@ var buttonsAttrs = { | |
|
||
method: { | ||
valType: 'enumerated', | ||
values: ['restyle', 'relayout'], | ||
values: ['restyle', 'relayout', 'animate'], | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🍻 |
||
dflt: 'restyle', | ||
role: 'info', | ||
description: [ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we have an in-house wrapper from translate transforms ->
Lib.setTranslate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure it's usable here since this crux of this method is the ability to pass transitions instead of selections. Example:
In other words, the getter does not work when a transition is supplied.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current master uses this technique: https://github.com/plotly/plotly.js/blob/master/src/components/drawing/index.js#L58