Skip to content

lib function to interleave trace updates into a restyle #847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions src/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -616,3 +616,42 @@ lib.numSeparate = function(value, separators) {

return x1 + x2;
};

/**
* Interleaves separate trace updates (frames) into a restyle command.
* Attributes not specified in both traces are set to `undefined` so that
* they are not altered by restyle. Object paths are *not* expanded.
*
* @example
* lib.interleaveTraceUpdates([{x: [1]}, {x: [2]}])
* // returns {x: [[1], [2]]}
*
* @param {array} traces the trace updates to be interleaved
*
* @return {object} an object contianing the interleaved properties
*/
lib.interleaveTraceUpdates = function(traces) {
var i, j, k, prop, trace, props;
var n = traces.length;
var output = {};

for(i = 0; i < traces.length; i++) {
trace = traces[i];
props = Object.keys(trace);
for(j = 0; j < props.length; j++) {
prop = props[j];
if(!output[prop]) {
// If not present, allocate a new array:
output[prop] = [];

// Explicitly fill this array with undefined:
for(k = 0; k < n; k++) {
output[prop][k] = undefined;
}
}
output[prop][i] = traces[i][prop];
}
}

return output;
};
28 changes: 28 additions & 0 deletions test/jasmine/tests/lib_test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1334,6 +1334,34 @@ describe('Test lib.js:', function() {
}).toThrowError('Separator string required for formatting!');
});
});

describe('interleaveTraceUpdates', function() {
it('wraps property updates in arrays', function() {
var input = [{x: [1], 'marker.color': 'red'}];
var output = Lib.interleaveTraceUpdates(input);

expect(output).toEqual({
x: [[1]],
'marker.color': ['red']
});
});

it('merges traces into a single restyle', function() {
var input = [
{x: [1], 'marker.color': 'red'},
{y: [[7, 8], [4, 2]], 'marker.goodness': 'very', symbols: {visible: 'please'}}
];
var output = Lib.interleaveTraceUpdates(input);

expect(output).toEqual({
x: [[1], undefined],
y: [undefined, [[7, 8], [4, 2]]],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

'marker.color': ['red', undefined],
'marker.goodness': [undefined, 'very'],
'symbols': [undefined, {visible: 'please'}]
});
});
});
});

describe('Queue', function() {
Expand Down