Adding pointcloud #850

monfera · 2016-08-12T15:26:20Z

This PR contains the plotly.js part of the new pointcloud2d trace type.

Work left involves

changing certain things about sizing
removing some disused marker options
image test cases
npm publish gl-pointcloud2d

etpinard · 2016-08-12T15:43:35Z

lib/index-gl2d.js

@@ -12,6 +12,7 @@ var Plotly = require('./core');

 Plotly.register([
 require('./scattergl'),
+ require('./pointcloud2d'),


Let's make this pointcloud !

OK, now done

etpinard · 2016-09-01T21:45:54Z

src/traces/pointcloud/attributes.js

+module.exports = {
+ x: scatterglAttrs.x,
+ y: scatterglAttrs.y,
+ xy: {


a dream come true

etpinard · 2016-09-01T22:06:32Z

@monfera Looks like the the autoscale and reset scale mode bar buttons don't work

I suspect that's caused by the doAutorange not finding all the required info.

We might want to have a look at 330c5f3

etpinard · 2016-09-01T22:07:27Z

Apart from the above comment and a few naming / styling issues this PR is looking amazing.

@monfera Thanks for all your hard work!

monfera · 2016-09-01T22:23:58Z

@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!

monfera · 2016-09-01T22:37:55Z

@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).

monfera · 2016-09-07T17:26:07Z

@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!

etpinard · 2016-09-07T18:18:04Z

src/traces/pointcloud/convert.js

+ if(xy) {
+
+ positions = xy;
+ len = xy.length >>> 1;


bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).

etpinard · 2016-09-07T18:24:52Z

src/traces/pointcloud/convert.js

@@ -96,6 +96,8 @@ proto.updateFast = function(options) {
 if(xy) {

 positions = xy;
+
+ // dividing xy.length by 2 and truncating to integer if xy.length was not even


thank you very much!

etpinard · 2016-09-07T20:15:28Z

Amazing work 💃

monfera force-pushed the pointcloud-squashed branch from db35191 to 98f90ad Compare August 12, 2016 15:33

etpinard reviewed Aug 12, 2016
View reviewed changes

monfera force-pushed the pointcloud-squashed branch from 98f90ad to 0deaccc Compare August 12, 2016 16:08

etpinard added feature something new status: in progress labels Aug 12, 2016

etpinard added this to the v1.17.0 milestone Aug 12, 2016

monfera force-pushed the pointcloud-squashed branch from 553975d to b45d3d7 Compare August 15, 2016 15:05

monfera force-pushed the pointcloud-squashed branch 3 times, most recently from 1860058 to 2f1005f Compare September 1, 2016 17:27

etpinard reviewed Sep 1, 2016
View reviewed changes

monfera force-pushed the pointcloud-squashed branch from c3dcf7d to 138a6e0 Compare September 2, 2016 18:01

etpinard removed this from the v1.17.0 milestone Sep 7, 2016

monfera force-pushed the pointcloud-squashed branch from 138a6e0 to b1da4c0 Compare September 7, 2016 17:04

monfera added 2 commits September 7, 2016 19:21

Pointcloud - plotly,js bindings (squashed)

3dd18ea

Pointcloud - image test

7b6edbc

monfera added 5 commits September 7, 2016 19:21

PR feedback - rename indexid to indices

95925a3

PR feedback - camelcasing

5f4847d

PR feedback- split bounds to xbounds / ybounds

bfd0af8

Add support for permutations of direct array support

6871cb3

Add support for permutations of direct array support - test cases

16f7fd5

monfera force-pushed the pointcloud-squashed branch from b1da4c0 to 16f7fd5 Compare September 7, 2016 17:23

etpinard added this to the v1.17.0 milestone Sep 7, 2016

Use the npm publish - ed version of gl-pointcloud2d

a69af31

monfera changed the title ~~[WIP] adding point cloud~~ Adding pointcloud Sep 7, 2016

removing the typed array based test cases as they aren't JSON

5d37b54

etpinard reviewed Sep 7, 2016
View reviewed changes

Added comment

8a09ccd

etpinard reviewed Sep 7, 2016
View reviewed changes

etpinard added status: reviewable and removed status: in progress labels Sep 7, 2016

jasmine test case for pointcloud

8105955

monfera force-pushed the pointcloud-squashed branch from 954845f to 8105955 Compare September 7, 2016 20:03

etpinard merged commit 06af109 into plotly:master Sep 7, 2016

This was referenced Sep 7, 2016

Add support for non-JSON image mocks #913

Closed

background color not showing in 3DMesh Plots #929

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding pointcloud #850

Adding pointcloud #850

monfera commented Aug 12, 2016 •

edited

Loading

etpinard Aug 12, 2016

monfera Aug 12, 2016

etpinard Sep 1, 2016

etpinard commented Sep 1, 2016 •

edited

Loading

etpinard commented Sep 1, 2016

monfera commented Sep 1, 2016

monfera commented Sep 1, 2016

monfera commented Sep 7, 2016

etpinard Sep 7, 2016

etpinard Sep 7, 2016

etpinard commented Sep 7, 2016

Adding pointcloud #850

Adding pointcloud #850

Conversation

monfera commented Aug 12, 2016 • edited Loading

etpinard Aug 12, 2016

Choose a reason for hiding this comment

monfera Aug 12, 2016

Choose a reason for hiding this comment

etpinard Sep 1, 2016

Choose a reason for hiding this comment

etpinard commented Sep 1, 2016 • edited Loading

etpinard commented Sep 1, 2016

monfera commented Sep 1, 2016

monfera commented Sep 1, 2016

monfera commented Sep 7, 2016

etpinard Sep 7, 2016

Choose a reason for hiding this comment

etpinard Sep 7, 2016

Choose a reason for hiding this comment

etpinard commented Sep 7, 2016

monfera commented Aug 12, 2016 •

edited

Loading

etpinard commented Sep 1, 2016 •

edited

Loading