Skip to content

Fix pandas future warning on create_choropleth #1856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2019
Merged

Fix pandas future warning on create_choropleth #1856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions packages/python/plotly/plotly/figure_factory/_county_choropleth.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
index=[max(gdf.index) + 1],
)
gdf = gdf.append(singlerow)
gdf = gdf.append(singlerow, sort=True)

f = 51515
singlerow = pd.DataFrame(
Expand All @@ -103,7 +103,7 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
index=[max(gdf.index) + 1],
)
gdf = gdf.append(singlerow)
gdf = gdf.append(singlerow, sort=True)

f = 2270
singlerow = pd.DataFrame(
Expand All @@ -120,19 +120,19 @@ def _create_us_counties_df(st_to_state_name_dict, state_to_st_dict):
columns=["State", "ST", "geometry", "FIPS", "STATEFP", "NAME"],
index=[max(gdf.index) + 1],
)
gdf = gdf.append(singlerow)
gdf = gdf.append(singlerow, sort=True)

row_2198 = gdf[gdf["FIPS"] == 2198]
row_2198.index = [max(gdf.index) + 1]
row_2198.loc[row_2198.index[0], "FIPS"] = 2201
row_2198.loc[row_2198.index[0], "STATEFP"] = "02"
gdf = gdf.append(row_2198)
gdf = gdf.append(row_2198, sort=True)

row_2105 = gdf[gdf["FIPS"] == 2105]
row_2105.index = [max(gdf.index) + 1]
row_2105.loc[row_2105.index[0], "FIPS"] = 2232
row_2105.loc[row_2105.index[0], "STATEFP"] = "02"
gdf = gdf.append(row_2105)
gdf = gdf.append(row_2105, sort=True)
gdf = gdf.rename(columns={"NAME": "COUNTY_NAME"})

gdf_reduced = gdf[["FIPS", "STATEFP", "COUNTY_NAME", "geometry"]]
Expand Down