Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate empty templates #1892

Merged
merged 2 commits into from
Nov 11, 2019
Merged

Propagate empty templates #1892

merged 2 commits into from
Nov 11, 2019

Conversation

jonmmease
Copy link
Contributor

When a template is explicitly set to {}, it is now replaced by {"data": {"scatter": [{}]}} so that it will not get overridden by a default template when a figure is passed along to other functions/libraries.

cc @nicolaskruchten

@nicolaskruchten
Copy link
Contributor

makes sense to me I think!

@jonmmease jonmmease added this to the v4.3.0 milestone Nov 11, 2019
@emmanuelle
Copy link
Contributor

Would it be possible to add a test which would have failed before this change? Like checking for a potential override of the template? Otherwise, 💃 (we can also add the test later -- if it makes sense to you)

@jonmmease
Copy link
Contributor Author

Would it be possible to add a test which would have failed before this change? Like checking for a potential override of the template?

@nicolaskruchten I don't remember exactly which use-cases you were having trouble with, are there any particular tests that you'd like to have in here?

@nicolaskruchten
Copy link
Contributor

The original issue was #1870 so it was with plotly.io.show() ... hard to test.

@jonmmease jonmmease changed the title Propagate emtpy templates Propagate empty templates Nov 11, 2019
@jonmmease
Copy link
Contributor Author

Ok, I'll go ahead and merge then.

@jonmmease jonmmease merged commit 0ccd082 into master Nov 11, 2019
@nicolaskruchten nicolaskruchten deleted the empty_template branch June 19, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants