update to plotly.js 1.51.2 #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hum a doctesting problem... let me know if you need help to fix this, I did some modifications when adding the doctesting and I might have broken stuff. |
|
Thank @emmanuelle, yeah if you have any ideas on this failure I'd appreciate it! Were these doctests passing previously as far as you know? |
emmanuelle
reviewed
Dec 9, 2019
| ['ggplot2', 'seaborn', 'simple_white', 'plotly', 'plotly_white', 'plotly_dark', ...] | ||
|
|
||
|
|
||
| >>> list(pio.templates) |
There was a problem hiding this comment.
This is the part which makes the doctest fails, the expected result is the line which was removed (probably I should have added it in the codegen and not here??).
There was a problem hiding this comment.
Ohh, I missed that in the diff. Yeah, I'll add it in the codegen. Thanks!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.