preload val_map from orders #2105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmanuelle
reviewed
Jan 21, 2020
emmanuelle
reviewed
Jan 21, 2020
| ) | ||
|
|
||
| for col in range(len(days)): | ||
| for trace in fig.select_traces(col=col + 1): |
There was a problem hiding this comment.
oh great I didn't know fig.select_traces :-). Not sure it's documented anywhere.
emmanuelle
reviewed
Jan 21, 2020
| @@ -182,3 +182,43 @@ def test_px_templates(): | |||
| assert fig.layout.xaxis3.showgrid is None | |||
| assert fig.layout.yaxis2.showgrid | |||
| assert fig.layout.yaxis3.showgrid | |||
|
|
|||
|
|
|||
| def test_orthogonal_orderings(): | |||
emmanuelle
reviewed
Jan 21, 2020
| @@ -182,3 +182,43 @@ def test_px_templates(): | |||
| assert fig.layout.xaxis3.showgrid is None | |||
| assert fig.layout.yaxis2.showgrid | |||
| assert fig.layout.yaxis3.showgrid | |||
|
|
|||
|
|
|||
| def test_orthogonal_orderings(): | |||
There was a problem hiding this comment.
Is it worth testing that adding in category_orders a value not present in the data does not break things?
There was a problem hiding this comment.
yeah I tried but it's a harder test to write and much slower :)
There was a problem hiding this comment.
OK I think I have a way to spot-check a few options
|
The approach (defining col and row numbers in advance) looks sound to me, and the test is very useful. 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2084 by populating
val_mapin a group-independent way. @emmanuelle thoughts on the approach?