Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TypeError: unhashable type: 'Template' during Figure construction #2447

Merged
merged 1 commit into from
May 7, 2020
Merged

Fix TypeError: unhashable type: 'Template' during Figure construction #2447

merged 1 commit into from
May 7, 2020

Conversation

jonmmease
Copy link
Contributor

... when plotly.io.templates.default is set to a Template object rather than a string.

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
  • I have added tests (if submitting a new feature or correcting a bug) or
    modified existing tests.
  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@jonmmease
Fix TypeError: unhashable type: 'Template' during Figure construc…
ca74302 
…tion

when `plotly.io.templates.default` is set to a `Template` object rather than a string.
@jonmmease jonmmease added this to the 4.7.1 milestone May 7, 2020
@jonmmease jonmmease requested a review from nicolaskruchten May 7, 2020 20:06
@jonmmease jonmmease changed the title Fix TypeError: unhashable type: 'Template' during Figure construction Fix TypeError: unhashable type: 'Template' during Figure construction May 7, 2020
@nicolaskruchten
Copy link
Contributor

Thanks @jonmmease !

@nicolaskruchten nicolaskruchten merged commit 580768c into master May 7, 2020
@nicolaskruchten nicolaskruchten deleted the template_default_as_object branch June 19, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolaskruchten nicolaskruchten Awaiting requested review from nicolaskruchten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.7.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jonmmease @nicolaskruchten