-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make test suite ready for NumPy 2.0.0 #4622
Conversation
packages/python/chart-studio/chart_studio/tests/test_optional/test_utils/test_utils.py
Outdated
Show resolved
Hide resolved
@bnavigator Is it okay if I push some changes here to handle both versions of numpy? |
Yes, of course. Sorry I do not have time to enhance it myself right now. |
e79e2d6
to
c9bdfbe
Compare
packages/python/plotly/plotly/tests/test_optional/test_utils/test_utils.py
Show resolved
Hide resolved
Thanks for tackling this issue.
|
I'm also seeing this error - you can see it's happening in the CI as well. I'm currently trying to investigate but if you figure anything out let me know! |
The recursion error is fixed! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
The soon to be released NumPy 2.0.0 removes some aliases of
np.nan
andnp.inf
, so these must be removed from the tests in order to keep the test suite green.Also, when testing data with small integer types like
int8
, the literals need to be cast beforehand in order to avoid overflow errors.References
Code PR
plotly.graph_objects
, my modifications concern thecodegen
files and not generated files.For a new feature, I have added documentation examples in an existing ornew tutorial notebook (please see the doc checklist as well).
I have added a CHANGELOG entry if fixing/changing/adding anything substantial.For a new feature or a change in behaviour, I have updated the relevant docstrings in the code to describe the feature or behaviour (please see the doc checklist as well).