Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back in express extra dependencies and required dependencies #5044

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

marthacryan
Copy link
Collaborator

@marthacryan marthacryan commented Feb 18, 2025

Fixes #5041 - @LiamConnors I haven't tested this through the CI artifacts yet but locally these changes are working for me!

Edit: tested the CI artifact and it's also working. Also, check out what it looks like in test.pypi.org! https://test.pypi.org/project/plotly/

@emilykl
Copy link
Contributor

emilykl commented Feb 18, 2025

Are we OK with getting rid of standalone requires-install and requires-express files? I can't think of any reason why it should be an issue, but not sure why we had them in the first place.

@marthacryan Make sure to remove them from MANIFEST.in.

@marthacryan
Copy link
Collaborator Author

@emilykl Those files were used as arguments for the setup.py, but they had so few requirements in them that I felt like it made more sense to just put them inline. It shouldn't cause any issues for anyone.

Also, I'll remove them from the MANIFEST.in~

Co-authored-by: Emily KL <4672118+emilykl@users.noreply.github.com>
Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@marthacryan marthacryan merged commit f878224 into main Feb 18, 2025
5 checks passed
@marthacryan marthacryan deleted the add-express-dep branch February 18, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release builds in CI not installing dependencies and not recognising [express] extra
2 participants