Remove failing ff.create_choropleth test
#5132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a chat with @marthacryan today about how to handle this failing test. Our conclusion is that since the
ff.create_choropleth()function has been deprecated anyway since 4 years ago, the best solution is to simply remove this test.The reason for the failure is that the
shapely2.1.0 release bumps the GEOS dependency version which changes the implementation of some geometric functions and causesshapelyto return slightly different values.Normally we could just update the expected value in the test, but unfortunately shapely 2.1.0 is not compatible with Python 3.9 and below so we'd have to either have two different expected values depending on which Python version is running the test, OR pin
shapely<=2.0.7indefinitely in the test suite, neither of which are great solutions.