Skip to content

Conversation

robertoffmoura
Copy link
Contributor

Use native legends (showlegend = true) instead of recreating them using shapes and annotations.

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

@gvwilson gvwilson requested a review from emilykl August 11, 2025 17:08
@gvwilson gvwilson added P1 needed for current cycle community community contribution fix fixes something broken labels Aug 11, 2025
@emilykl
Copy link
Contributor

emilykl commented Aug 11, 2025

Thank you for the contribution @robertoffmoura ! This is great.

Could you run ruff format on the modified files and commit the changes, so that the code_formatting CI job will pass?

(There's a failure in build as well but that one looks unrelated to this PR.)

@robertoffmoura
Copy link
Contributor Author

Thanks, Emily! Done, just pushed a new commit after running ruff format.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks again @robertoffmoura 🚀

@emilykl emilykl merged commit aa4c088 into plotly:main Oct 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community community contribution fix fixes something broken P1 needed for current cycle

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants