Fix Plotting Error in other domains besides plot.ly #622
Conversation
|
|
||
| link_domain = plotly_platform_url\ | ||
| .replace('https://', '')\ | ||
| .replace('http://', '') | ||
| link_text = link_text.replace('plot.ly', link_domain) | ||
| link_text = config['linkText'].replace('plot.ly', link_domain) | ||
| config['linkText'] = link_text |
There was a problem hiding this comment.
It's plotting now 🎉
However, the link_text remains: 'Export to plot.ly' while it looks like it should be replaced with the domain
|
cool! want to take one more 👀 at replacing the link text @Kully
as suggested here: #621 (comment) |
|
@Kully great!! can you update the changelog then looks good to 💃 ! |
|
@cldougl Let me know if the CHANGELOG looks okay. I know you had to change my wording on other sections :) |
| @@ -2,7 +2,9 @@ | |||
| All notable changes to this project will be documented in this file. | |||
| This project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|
|||
| ## [Unreleased] | |||
| ## [1.12.11] | |||
| ## [Unreleased] | ||
| ## [1.12.11] | ||
| ### Fixed | ||
| - Offline plotting now works in other domains besides `plot.ly`. In addition, the `link text` in the bottom right corner of the offline plots properly display `Export to [Domain Name]` for the given Domain name of the server. |
There was a problem hiding this comment.
ahh this may seem nitpicky but offline plotting doesn't work 'in' a given domain (cause it's offline), it was just an issue with the link text not getting assigned at the right time. This could just be:
The link text in the bottom right corner of offline plots now properly displays Export to [Domain Name] for the given domain set in the user's .config file.
Fixing #621