Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved compatibility with ipywidgtes and jupyter notebook #641

Closed
wants to merge 1 commit into from

Conversation

mtomassoli
Copy link

Please review & test this. I fixed it out of necessity but I only tested this on my own system.

This should solve issue #490.

@theengineear
Copy link
Contributor

Thanks for the PR @mtomassoli, I'll do some manual testing ASAP.

@etpinard
Copy link
Contributor

etpinard commented Jan 6, 2017

... with #549 now merged, we could now add a few test cases for widgets in NBs.

@rskabelund
Copy link

Hello, wondering if this ever made it into master? Also, wondering about Jupyter 5.0 compatibility?

@dmourot
Copy link

dmourot commented May 11, 2017

Hi, i tried this on my computer with ipython 5.1.0 and it's working.
graphWidget.js is now on package_data/ so you need to apply small fix. I can provide a patch if you need to.
What is the next step to merge this into master ?
Thanks

@rskabelund
Copy link

rskabelund commented May 25, 2017

@Nahman78 please elaborate on the small fix. I have been having to do so many workarounds to use plotly in Jupyter that I think could have been addressed using the graphwidget...

@stathius
Copy link

stathius commented Jun 7, 2017

Hi, I've managed to apply the fix locally and works fine. stathius@c55f2a9

Is there a plan to merge it?
Thanks

@cleb11
Copy link
Contributor

cleb11 commented Sep 11, 2017

Any updates? I am still facing the same problem.

@astrojuanlu
Copy link
Contributor

Do the plotly developers have plan to include these updates, or perhaps are they working on an alternative approach? Not sure how #490 and #627 relate to #821 and jupyterlab/jupyter-renderers#3. Any feedback would be appreciated, as I think there are a handful of people tracking those issues.

@jackparmer
Copy link
Contributor

jackparmer commented Nov 20, 2017

We're looking for some outside help for this and #821. No one at plotly has had time for the past year. Email me at jack at plot dot ly if interested.

@jackparmer
Copy link
Contributor

jackparmer commented Dec 12, 2017

@CalebS97 merged your PR here

GraphWidget is working OK for me on IPython v6.2.1, Python v3.6.3

image
Please let the thread know if you spot any issues.

@jonmmease
Copy link
Contributor

Closing as FigureWidget has replaced the functionality of GraphWidget in version 3.

@jonmmease jonmmease closed this Sep 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants